Add --scalar-columns parameter to NIfTI and MIF CLIs#34
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 61.19% 61.14% -0.06%
==========================================
Files 16 17 +1
Lines 951 1045 +94
Branches 137 170 +33
==========================================
+ Hits 582 639 +57
- Misses 332 360 +28
- Partials 37 46 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think the way to go here is to make multiple h5 files, since using that is supported in ModelArray now. This won't make a difference for tiledb, since the scalars all go into different files in its root directory anyways. Separate h5's let users mix and match when modeling and also the reshaping from long to wide during the ModelArray runs adds up |
|
When providing a wide-form cohort tsv and |
mattcieslak
left a comment
mattcieslak
left a comment
There was a problem hiding this comment.
This is great! Only minor non-blocking comments. Thank you!!
|
|
||
| - ``*-to-h5`` commands: convert input neuroimaging data into either: | ||
| - one or more HDF5 files (``--backend hdf5``), or | ||
| - one or more TileDB directories (``--backend tiledb``). |
There was a problem hiding this comment.
I believe it will write data blobs with different names to the tiledb directory. Haven't tested this though
|
|
||
| def test_nifti2_to_mif_raises_when_mrconvert_missing(tmp_path, monkeypatch) -> None: | ||
| monkeypatch.setattr(fixels, 'find_mrconvert', lambda: None) | ||
| monkeypatch.setattr(mif, 'find_mrconvert', lambda: None) |
Co-authored-by: Matt Cieslak <mattcieslak@gmail.com>
num_subjects --> n_files num_items --> n_elements
num_elements --> n_elements num_voxels --> n_voxels
|
@mattcieslak do you want to take another look or should I merge? |
3 participants
Closes #32. Closes #33.